Skip to content

Allow NIO HTTPDecoder to correctly support informational responses #470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 9, 2021
Merged

Allow NIO HTTPDecoder to correctly support informational responses #470

merged 1 commit into from
Nov 9, 2021

Conversation

fabianfett
Copy link
Member

Motivation

SwiftNIO supports informational responses since apple/swift-nio#1984. However this has broken an overly specific test case in AHC.

Changes

  • Modify test case HTTP1ConnectionTests.testConnectionDoesntCrashAfterConnectionCloseAndEarlyHints to support both behaviors

Result

Tests run with NIO main branch.

@fabianfett fabianfett added the semver/none No version bump required. label Nov 9, 2021
@fabianfett fabianfett requested a review from Lukasa November 9, 2021 14:09
@fabianfett fabianfett merged commit d49602f into swift-server:main Nov 9, 2021
@fabianfett fabianfett deleted the ff-fix-failing-test-with-nio-main branch November 9, 2021 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lukasa Lukasa Lukasa approved these changes

Assignees
No one assigned
Labels
semver/none No version bump required.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fabianfett @Lukasa